-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update with master #6722
update with master #6722
Conversation
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
… are locked (binary-com#4644) * Ignore IDV verification if client is high risk * Fix formatting * Fix cfd-poi issue due to client store unavailability * Fix formatting * Merge with master * Fix formatting * Merge with master * Revert "Merge with master" This reverts commit 4bead99. * Fix merge issues * Chain extra condition to cover wrong status returned from BE * Fix: wrong component shown when manual upload is triggered
…s to TS (binary-com#6361) * perf(cashier routes): convert csahier routes to TS * perf(cashier routes): convert error-component to TS * refactor(error-dialog, types): refactor error-dialog types, move error type to shared types * perf(cashier): convert cashier to TS * perf(types): refactor types * refactor(routes with sub routes): refactor default subroute * refactor(types): add/refactor server error type * test: refactor pathname * refactor(route types): refactor route types * fix: fix ts error in React.Suspense
…#6343) * perf(cashier withdraw): convert withdrawal-verification-email to TS * perf: add data-testid for checklist action * perf(cashier withdraw): convert withdrawal-locked to TS * perf(types): add types for TClinetStore * perf(cashier withdraw): convert withdraw to TS * perf(cashier withdraw): convert crypto-withdraw-receipt to TS * perf(cashier withdraw): convert crypto-withdraw-form to TS * perf(cashier withdraw): convert withdrawal to TS * refactor(cashier withdraw): refactor array syntax (ts) * test(cashier withdraw): remove eslint disables for tests
…thdraw all his allowable withdrawal amount (binary-com#6032) * fix(cashier): ✨ handle `PACommisionWithdrawalLimit` state in `CashierLocked` * test(cashier): ✅ add test case to `CashierLocked` for `PACommisionWithdrawalLimit` * Trigger Build
* chore: update appstore tsconfig * chore: update appstore tsconfig * chore: add react and types/react packages to appstore * refactor: remove unnecessary includes * refactor: change from reexports to import -> export
…6275) * fix: trader typscript configuration issue * fix: tsc errors on trader
…m#6276) * chores: add typescript configuration on reports * fix: remove extra paths * fix: revert removing packages
* refactor(p2p-cashier): migrate p2p-cashier component to TS * commit * perf(types): add types for notification store * perf(types): add types for ui store * perf(types): convert p2p-cashier to TS * refactor(types): change RootStore type to TRootStore * test(p2p-cashier): test fix (change wrapper order fro p2p-cashier component) * refactor(types): refactor current_focus type * test(p2p-cashier): remove eslint disables
* refactor: converted on-ramp module into typescript * refactor: included type related to store in on-ramp * ts fix in on-ramp-provider-card.spec.tsx * added path in tsconfig * added path in tsconfig * added type for react-router-dom * added ts related change required for migrating all components (binary-com#5760) * changed the name of data-testid in on-ramp component * ts-migration-crypto-fiat-converter (binary-com#5796) * Trigger build * Update package-lock * ts-migration-cashier-notifications (binary-com#5765) * implemented review comments and updated branch as per latest upstream branch * bahar/funds_protection_component-ts-migration (binary-com#5756) * funds_protection_component-ts-migration * remove_extra_type_file * fix_merge_issue * hamid/migrate-transfer-confirm-to-ts (binary-com#5815) * Migrate TransferConfirm to TS * Rename component in test file * Replace Confirm with TransferConfirm in PAs * Enhance Tests * ts-migration-page-404 (binary-com#5766) * corrected imports in on-ramp pages * coreected setSideNotes type in on-ramp file * arranged the order of imports in on-ramp * refactor: add menu-option type to types folder in cashier * replaced type for FormEvent in on-ramp from Types * added types from TRootstore * added types of TClientStore, TUiStore and TCommonStore in on-ramp Co-authored-by: Nijil Nirmal <nijil@deriv.com> Co-authored-by: Bahar <bahar@firstsource.tech> Co-authored-by: Hamid <hamid@re-work.dev>
* Migrate Account Transfer to TS * Enhance type names * Remove eslint ignore line * Remove generic type from useState * trigger tests * Fix test errors * Change data-testid name
…6273) * fix: account typscript configuration issue * text: remove include comment on account tsconfig
* fix: circle ci issue * fix: circle ci issue
…y-com#6306) * build: add typescript to all packages * build: move typescript to devdependency * add some TS configs to eslint file * fix: conflicts
* checking circle/ci test * removed test changes * fix: updated tsconfig and fixed some errors * fix: updated tsconfig and added globals.d.ts * chore: removed experimentalsDecorators from local config
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
* Fix sidenote in mobile view of account-transfer * Remove duplicate title * Add sideNote title
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
…y-com#6177)" (binary-com#6424) This reverts commit 503e77e.
* carol/ P2P: 2FA (binary-com#6009) * add: icons * add: one more icon * add email verification modal * add invalid verification link modal * add email verified * add email blocked modal * add email blocked modal * use align prop instead * carol/ P2P: Email verification for orders (binary-com#6299) * fix: quotes * add: email verification * cleanup * don't kill me * add response checks * add comment * add: amount + currency * fixed loading of order details and chat * fixed design on responsive * fixed verification modal in responsive * show modal if error * fix * fixed truncated modal in ios * fix time * fix invalid verification modal * fix * fix * fixed verification modal in desktop * fix responsive +logged out user * fix: design for seller * the solution to all my problems * fix: modal * fix logout + modal * hide extra modal * i got 99 problems and 2fa is all of em * fix * fix * fix: amount * fix: amount * fix: add modal * fix: rating modal Co-authored-by: Farrah Mae Ochoa <farrah@deriv.com> Co-authored-by: Nijil Nirmal <nijil@deriv.com> Co-authored-by: Farrah Mae Ochoa <farrah@deriv.com>
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
…m#6284) * checking circle/ci test * removed test changes * fix: updated ts config and fixed two errors returnd by tsc * fix: fixing errors returned by tsc (WIP) * fix: fixed all ts errors * chore: removed experimentalDecorators from tsconfig * fix: removed unnecessary path from tsconfig * fix: type added to transfer_to_hint
…inary-com#6027) * fix(components): 🐛 fix date picker month issue for non english languages by setting moment locale to `en` * refactor(components): ♻️ refactor `calendar-months` component to rely on month number instead of month name * fix(components): 🌐 add localization support for date picker month names * refactor(components): 🔥 remove redundant `month_headers` * chore(components): ➖ remove redundant `@deriv/translations` dependency * Trigger Build * fix(cashier): 📝 resolve PR comments
* Added dark theme to the bot * Added dark theme details * Removed extra comments * Changed color variable to const * Trigger build * Added # before color * Added theme color to the journal text * Added flyout border color * Added plus color * Fixed issue with QS cform color * Fixed issue with whas this color * Changed summary bgcolor * Fixed issue with section colors * Changed the dropdown menu item colors * Fixed issue with journal bg color * Changed tooltip color * Changed color of transaction * Added dark theme to smartchart * Added dark theme menu to bot * Changed numpad color * Added animation to contractloader * Changed line color in summary * Changed block menu color Co-authored-by: Farrah Mae Ochoa <82315152+farrah-deriv@users.noreply.github.com>
* fix(cashier): 🐛 fix `tsconfig` * feat(shared): ✨ expose `WS` object from `shared` package via `useWS` * feat(cashier): ✨ add `useCountdown` hook * feat(cashier): ✨ add `useWS` hook * feat(cashier): ✨ add `useStore` hook and `StoreContext` * feat(cashier): ✨ add `useVerifyEmail` hook * test(cashier): ✅ add test for `useCountdown` hook * test(cashier): ✅ add test for `useWS` hook * fix(cashier): 📝 resolve PR comments * fix(cashier): 📝 resolve PR comments * fix(cashier): 📝 resolve PR comments * fix(cashier): 📝 resolve PR comments * refactor(cashier): ♻️ improve types for `useWS` hook
* added ts related change required for migrating all components (binary-com#5760) * ts-migration-crypto-fiat-converter (binary-com#5796) * Trigger build * Update package-lock * ts-migration-cashier-notifications (binary-com#5765) * bahar/funds_protection_component-ts-migration (binary-com#5756) * funds_protection_component-ts-migration * remove_extra_type_file * fix_merge_issue * hamid/migrate-transfer-confirm-to-ts (binary-com#5815) * Migrate TransferConfirm to TS * Rename component in test file * Replace Confirm with TransferConfirm in PAs * Enhance Tests * ts-migration-page-404 (binary-com#5766) * Vinu/converted percentage-selector component into typescript (binary-com#5785) * converted percentage-selector component into typescript * changed the name of test_ids in percentage-selector spec file as per new guidlines * updated with latest upstream branch * added reactMouse event in props.types.ts * Vinu/migrated recent-transaction component to typescript (binary-com#5791) * migrated recent-transaction component to typescript * fixed Rootsore path in recent-transaction * tsconfig.json change in types path * ts-migration-verification-email (binary-com#5769) * bahar/Ts migration no balance (binary-com#5774) * ts-migration-no-balance * fix_merge_issue * Vinu/migrating cashier-container into ts (binary-com#5780) * migrting cashier-container into ts WIP * added type in virtual.tsx * changed test-ids in cashier-container * updated the branch with latest upstream branch * fixed Rootsore path in cashier-container * tsconfig.json change in types path * refactor(cashier): ♻️ extract empty state component into a reusable component * refactor(cashier): ✨ extract all cashier empty states into separate components * refactor(cashier): 🔥 clean up cashier locked component using empty states * fix(cashier): ✏️ fix wrong message in `EmptyStateDepositLockedSystemMaintenance` * Vinu/Ts cashier error dialog (binary-com#5820) * migrated error-dialog to typescript * removed proptypes from error-dialog * added appropriate types to message variable in error-dialog * updated code with latest upstream branch * fixed type of rootstore in error-dialog * fixed Rootsore path in error dialog * added type for ReactElement in props.types.ts cashier * Vinu/migration of crypto-transaction-history component into typescript (binary-com#5834) * migration of crypto-transaction-history component into typescript * Trigger Build * Trigger Build * fixed Rootstore path in crypto-transactions-history * added type for crypto-transaction-details * added ReactMouseEvent in prop.types * added data-testid's in crypto-transaction-renderer component * Migrate CashierLocked to TS (binary-com#5959) * Fix security hotspot reported by sonarcloud * fix(cashier): 📝 resolve PR comments * fix(cashier): 📝 resolve PR comments * fix(cashier): 📝 resolve PR comments * fix(cashier): 📝 resolve PR comments * refactor(cashier): ♻️ refactor the initial solution with the suggested one in the pr comments * fix(cashier): ✅ fix the failing test * fix(cashier): 📝 resolve PR comments * fix(cashier): 📝 resolve PR comments * chore(cashier): 🔀 resolve merge conflic * fix(cashier): 💄 fix inconsistenc padding in cashier tabs when cashier locked * fix(cashier): 📝 resolve PR comments * feat(cashier): ✨ handle `PACommisionWithdrawalLimit` state in `CashierLocked` Co-authored-by: vinu-deriv <100689171+vinu-deriv@users.noreply.github.com> Co-authored-by: Nijil Nirmal <nijil@deriv.com> Co-authored-by: Bahar <bahar@firstsource.tech> Co-authored-by: Hamid <hamid@re-work.dev>
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
* build/ update lerna-nx and use nx scripts * build/ add nx config file * build/ add nx token key * build/ replace build scripts with nx * build/ run build local in parallel * ci/ update build command * ci/ update build command * build/ update package-lock * build/ update nx script * build/ remove deprecated --all flag * build/ update nx to latest version * build/ update package-lock file * config/fix cacheOperation for linting * build/ update package-lock file * ci/ fix nx accesstoken * build/ update package-lock * ci/ add nx-cloud env example file * ci/ add nx-cloud env example file * build: use nx build for build:travis script * build/ update lerna to 5.5.1 * ci/ use process.env to get nx accessToken
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## pre-appstore #6722 +/- ##
===============================================
Coverage ? 21.30%
===============================================
Files ? 1532
Lines ? 34001
Branches ? 5932
===============================================
Hits ? 7245
Misses ? 26279
Partials ? 477 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…pre_appstore_with_master
Deployment failed with the following error:
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
Kudos, SonarCloud Quality Gate passed! |
Changes:
Please include a summary of the change and which issue is fixed below:
When you need to add unit test
When you need to add integration test
Test coverage checklist (for reviewer)
Type of change